Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
719 Commits 2 Branches 60 Tags 4.6 MiB
Commit Graph

75 Commits

Author SHA1 Message Date
Martchus 25458a0ca7 Do not allow changing tag target of Ogg Vorbis comments 
It has no effect anyways as tagparser does not allow to move a Vorbis
comment from one stream to another this way.
 2022-05-03 23:54:46 +02:00
Martchus 79d9e1b9d4 Fix spelling mistakes 2022-04-12 01:16:27 +02:00
Martchus 32c9cbaae2 Use `makeNativePath()` instead of `u8path()` 
On non-Windows platforms the internal representation used for paths is the
configured native (narrow) character set. Most of the time that's UTF-8 but
only on Windows UTF-8 is *always* used for the internal representation.
 2022-03-17 22:41:51 +01:00
Martchus 7f1e234f36 Fix occurrences of wrong encoding handling with `std::filesystem` 2022-03-16 19:51:54 +01:00
Martchus dfc7b9ebe5 Fix issues when loading file within GUI 
* Update file info before creating tags so the file info actually
  represents the file's state on disk
* Fix treating unknown files as MP3 by using the correct flag
  (`TagCreationFlags::TreatUnknownFilesAsMp3Files`)
 2021-09-06 18:28:13 +02:00
Martchus 1e084f8eae Add option to preserve "modification date" on file saving for UI 
See https://github.com/Martchus/tageditor/issues/67
 2021-08-21 01:22:29 +02:00
Martchus b4d1df8592 Fix typos found via `codespell --skip .git -w` 2021-07-03 19:38:36 +02:00
Martchus a9f3a607a3 Improve showing IO errors 
* Make error messages and dialogs more consistent
* Print the actual error message (which might actually contain something
  useful when NativeFileStream is used)
 2021-06-01 22:36:48 +02:00
Martchus d31fd79e87 Adapt to changes in tagparser library 2021-04-23 22:18:30 +02:00
Martchus e535e20720 Fix warnings 2021-03-20 21:59:49 +01:00
Martchus 1a2427d1dc Fix passing/livetime of AbortableProgressFeedback in TagEditorWidget::startParsing() 2021-02-15 23:45:39 +01:00
Martchus e3eff819ec Avoid catchinng all exceptions without re-throwing them 
This shouldn't be required and leads to problems when `pthread_cancel`
would be used: https://udrepper.livejournal.com/21541.html

Note that the tagparser library itself does not contain any `catch (...)`
blocks (which do not re-throw).
 2021-02-11 16:54:18 +01:00
Martchus 9fbb375924 Adapt to changes in tagparser (without making actually use of the new API) 2021-02-04 23:22:43 +01:00
Martchus 16c1d96a28 Avoid nesting in parsing/error handling code 2021-02-02 15:05:45 +01:00
Martchus 31904ff084 Support Qt 6 (commit 174154b) 2020-09-04 00:59:22 +02:00
Martchus 20c1d88629 Avoid useless use of QTextStream 2020-05-13 18:42:17 +02:00
Martchus 0370b1320e Avoid web view appearing as white rectangle when no file is opened 
* Hide web view (and for consistency reglar info view) when no file opened
* The white rectancle is otherwise disturbing when a dark theme is used
 2020-04-26 21:49:01 +02:00
Martchus c05a976bac Apply clang-format 2020-04-24 23:26:52 +02:00
Martchus 226ee9f230 Add TODO regarding ID3v2 version 2020-04-24 23:09:24 +02:00
Martchus 976bcbb2e8 Show document title at the top of line edit 
It takes more space but just looks better.
 2020-03-19 16:24:32 +01:00
Martchus a4ae94d0b5 Fix adding "required" targets 2019-12-31 01:42:41 +01:00
Martchus 74afa6e827 Improve canceling 
* Show a specific status messages
* Allow aborting while only the percentage is updated
 2019-12-30 23:54:04 +01:00
Martchus 864fd1c901 Fix remaining context menus for Wayland 2019-07-20 18:49:32 +02:00
Martchus 376b15a06e Fix warnings in TagEditorWidget::updateDocumentTitleEdits() 2019-07-20 17:59:18 +02:00
Martchus 66c9250246 Adapt to changes in c++utilities 2019-06-10 22:49:46 +02:00
Martchus cf71ac5dca Add info about auto-correction when opening file 2019-06-01 12:53:44 +02:00
Martchus 1691b9daa2 Adapt to c++utilities v5 2019-05-04 16:05:20 +02:00
Martchus 2a5d71cf87 Fix using backup directory in GUI 2018-07-14 22:38:25 +02:00
Martchus 15d7ec38ff Fix possibly missing #includes 2018-06-05 22:46:02 +02:00
Martchus 95ac0d6aa7 Include QHeaderView explicitely 
To avoid error: invalid use of incomplete type ‘class QHeaderView’
 2018-05-28 19:52:13 +02:00
Martchus 70ee0be17b Improve coding style 2018-05-26 22:43:35 +02:00
Martchus 2250b9aa47 Ensure MediaFileInfo isn't destroyed before concurrent operation finishes 2018-05-26 22:43:27 +02:00
Martchus 645ca8a457 Improve coding style in tageditorwidget.cpp 2018-04-29 19:02:31 +02:00
Martchus 4f21442f39 Set writing application 2018-03-20 21:41:42 +01:00
Martchus 6efeeb828a Improve 'Keep previous values' button 2018-03-14 19:35:52 +01:00
Martchus 4f53029a6e Refactor MediaFileInfo::createAppropriateTags() 2018-03-11 18:58:20 +01:00
Martchus 4b7d7a9499 Apply clang-format 2018-03-07 01:18:01 +01:00
Martchus c1a3e53dc9 Move tagparser to namespace TagParser 2018-03-06 23:10:13 +01:00
Martchus c2b2e4ac44 Adapt to new notification handling 2018-03-06 22:43:51 +01:00
Martchus 799f76e5ab Use QMessageBox::critical consistently 2018-01-31 21:04:50 +01:00
Martchus 25d570d394 Allow opening HTML file info in browser 2017-09-20 19:37:49 +02:00
Martchus fe0dccf019 Fix some warnings 2017-08-20 02:01:37 +02:00
Martchus d3e2c89a0b Show notifications in msgbox on double click 2017-07-30 20:57:55 +02:00
Martchus 039f64584e Use web view defs provided by qtutilities 2017-03-14 23:37:50 +01:00
Martchus 7d464f496f Consider all strings from tagparser UTF-8 2016-12-20 23:53:33 +01:00
Martchus e75ea5526a Use _wopen under Windows to support unicode filenames 2016-12-19 23:53:12 +01:00
Martchus 733fe08890 Allow auto-insert of DB query results 2016-12-01 22:54:16 +01:00
Martchus d3558cfefe Refactor GUI 
* Make error handling more clear
* Get rid of useless mutex (sync is done
  by QMetaObject::invokeMethod() already)
* Improve details
 2016-11-23 21:46:33 +01:00
Martchus 1924c1d804 Handle unexpected exceptions when parsing/making 
* Don't just ignore exception (previous behavior)
* Add critical notification
* Show results, though error (to ease debugging)
 2016-11-13 22:57:02 +01:00
Martchus 0ef07b7969 Refactor settings 2016-10-24 20:17:30 +02:00