syncthing/lib/model
Jakob Borg ebd2e5bf30
lib/model: Correctly handle manual rescan with ignore error (fixes #5985) (#5987)
Assume a folder error was set due to bad ignores on the latest scan.
Previously, doing a manual rescan would result in:

1. Clearing the folder error, which schedules (immediately) an fs
   watcher restart

2. Attempting to load the ignores, which fails, so we set a folder
   error and bail.

3. Now the fs watcher restarts, as scheduled, so we trigger a scan.
   Goto 1.

This change fixes this by not clearing the error until the error is
actually cleared, that is, if both the health check and ignore loading
succeeds.
2019-08-30 13:27:26 +01:00
..
testdata lib/fs, lib/model: Make tests caching compatible (fixes #4749) (#4804) 2018-03-13 14:03:10 +01:00
bytesemaphore.go lib/model: Allow limiting number of concurrent scans (fixes #2760) (#4888) 2018-12-05 08:40:05 +01:00
bytesemaphore_test.go lib/model: Allow limiting number of concurrent scans (fixes #2760) (#4888) 2018-12-05 08:40:05 +01:00
debug.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
deviceactivity.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
deviceactivity_test.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
devicedownloadstate.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
devicedownloadstate_test.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
doc.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
fakeconns_test.go lib/model, lib/testutils: Test closing a connection on folder restart (#5707) 2019-05-18 08:53:59 +02:00
folder.go lib/model: Correctly handle manual rescan with ignore error (fixes #5985) (#5987) 2019-08-30 13:27:26 +01:00
folder_recvonly.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
folder_recvonly_test.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
folder_sendonly.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
folder_sendrecv.go lib/model: Do free disk space check later on pull (fixes #5948) (#5949) 2019-08-16 09:40:53 +02:00
folder_sendrecv_test.go lib/model: Optimise locking around conn-close and puller states (#5954) 2019-08-16 09:35:19 +02:00
folder_summary.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
folder_test.go all: Display errors while scanning in web UI (fixes #4480) (#5215) 2018-11-07 11:04:41 +01:00
folderstate.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
model.go lib/model: Optimise locking around conn-close and puller states (#5954) 2019-08-16 09:35:19 +02:00
model_test.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
progressemitter.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
progressemitter_test.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
queue.go lib/model: Make jobQueue.Jobs paginated (fixes #5754) (#5804) 2019-06-27 19:25:38 +01:00
queue_test.go lib/model: Make jobQueue.Jobs paginated (fixes #5754) (#5804) 2019-06-27 19:25:38 +01:00
requests_test.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
sentdownloadstate.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
sharedpullerstate.go lib/model: Optimise locking around conn-close and puller states (#5954) 2019-08-16 09:35:19 +02:00
sharedpullerstate_test.go lib/model: Use errors.Wrap for pull errors (#5563) 2019-03-04 13:01:52 +00:00
testos_test.go lib/model: Introduce must test utility (#5586) 2019-03-09 18:45:36 +00:00
testutils_test.go all: Remove global events.Default (ref #4085) (#5886) 2019-08-15 16:29:37 +02:00
util.go all: Remove potentially problematic errors from panics (fixes #5839) (#5912) 2019-07-31 10:53:35 +02:00
utils_test.go all: Remove potentially problematic errors from panics (fixes #5839) (#5912) 2019-07-31 10:53:35 +02:00