c8457ab005
Voodoo
2015-06-15 10:22:44 +01:00
070a308217
Dont warn about irrelevant symlinks, print path to culprit (ref #1945 )
...
This skips the warning about "unsupported symlinks" for invalid or
deleted symlinks (and as a side effect also accepts them into the index,
which should be fine). It also prints the affected file paths to the
log. This should be in the hypothetical list of "errored files" we
should present instead of the cryptic "puller stopped" message in the
future...
2015-06-15 00:47:13 +02:00
c1f4477376
ItemStarted can be map[string]string
2015-06-14 22:59:21 +02:00
d728320ece
New ItemStart/Finished type 'metadata' for shortcut updates
2015-06-14 22:56:41 +02:00
1437952aee
Translation and docs update
2015-06-14 13:52:00 +02:00
1d856b4723
Correctly set and clear errors for missing folders ( fixes #1937 )
2015-06-13 23:45:54 +01:00
a778763851
Add trash can file versioning ( fixes #1931 )
2015-06-12 13:30:49 +02:00
297769ef57
More resilient broadcast handling ( fixes #1907 )
...
My theory is that some error condition on the socket results in it
blocking for writes, which maybe also blocks reads... This separates the
two into separate services with their own socket, with restarts and
retries as appropriates on write timeouts and read/write errors. It
should be more robust, hopefully, but I have a hard time testing the
actual error conditions...
2015-06-11 15:06:05 +02:00
42738ab54d
Add missing copyright notice
2015-06-11 08:46:57 +02:00
76ad925842
Refactor config commit stuff to support restartless updates better
...
Includes restartless updates of the GUI settings (listening port etc) as
a proof of concept.
2015-06-09 15:41:22 +02:00
a8b43ae598
Translation / docs update
2015-06-07 12:57:26 +02:00
567f19bf68
Do not overwrite error value
2015-06-06 08:30:01 +01:00
4180569443
Silence discovery warnings ( fixes #1388 )
...
Not performing net.InterfaceAddrs() check in the constructor, as that means we wouldn't start
the read loop, which completely kills it.
2015-06-04 12:59:06 +01:00
11cb040ad1
Merge pull request #1880 from calmh/itemfinished-err
...
Fix ItemFinished
2015-06-03 16:50:33 +01:00
c1761cab49
Trigger ItemFinished when temp file creation fails instead of failing silently
2015-06-03 16:28:31 +02:00
25b25b5434
Merge pull request #1885 from AudriusButkevicius/moar-checks
...
Additional cases for detecting folders disappearing
2015-06-03 08:40:21 +02:00
ccebdd142a
fix webgui top menu for small screen devices
2015-06-02 17:48:31 +03:00
e952da7f91
Ensure we always have an up to date list of language names
2015-06-02 08:47:26 +02:00
5bd1e4a167
Re-add mistakenly removed languages
2015-06-02 08:33:36 +02:00
f11bac6705
fix missing languages ( fixes #1902 )
2015-06-02 01:19:21 +03:00
36d4c69fd6
Translation update
2015-05-31 09:37:02 +02:00
d632e3aa1b
Show help link, add icons, tweak icon spacing
2015-05-30 10:31:45 +02:00
f0e58fa804
Additional cases for detecting folders disappearing
2015-05-27 22:46:10 +01:00
7d48115b90
Reduce db writes for small files
...
We introduced the dbUpdater routine to handle many small files
efficiently, but the folder stats call is almost equally expensive as it
results in two distinct write transactions to the database. This moves
it to the same routine.
(Doesn't make a *huge* difference with leveldb actually, but reduces the
50k-files benchmark time by 25% on my experimental bolt branch...)
2015-05-27 18:36:26 +02:00
d2205228fb
Make syncthing honor both the ignorePerms and FlagNoPermBits settings ( fixes #1871 )
2015-05-26 16:27:26 +02:00
3f59d6daff
Add validation cache
2015-05-25 13:19:18 +02:00
0d659933aa
Merge pull request #1868 from mogwa1/umask
...
Change permissions of newly created files and directories (fixes #1339 )
2015-05-25 08:34:34 +02:00
3e8eabe833
Add mogwa1
2015-05-25 08:07:59 +02:00
badfc77339
Change permissions of newly created files and directories ( fixes #1339 )
2015-05-25 00:12:51 +02:00
c0d02a65c3
Reduce allocations during iteration
...
Reuses key byte slices to reduce allocations:
benchmark old allocs new allocs delta
Benchmark10kReplace 178112 168615 -5.33%
Benchmark10kUpdateChg 567954 561557 -1.13%
Benchmark10kUpdateSme 238691 228680 -4.19%
Benchmark10kNeed2k 105382 103383 -1.90%
Benchmark10kHaveFullList 60230 60230 +0.00%
Benchmark10kGlobal 237484 227493 -4.21%
benchmark old bytes new bytes delta
Benchmark10kReplace 8725368 7661788 -12.19%
Benchmark10kUpdateChg 58155152 57441025 -1.23%
Benchmark10kUpdateSme 16130875 14996717 -7.03%
Benchmark10kNeed2k 6561685 6338283 -3.40%
Benchmark10kHaveFullList 7611112 7611135 +0.00%
Benchmark10kGlobal 21415056 20300723 -5.20%
2015-05-24 13:08:14 +02:00
3a203b8d83
Merge pull request #1861 from calmh/fix-1860
...
Be more lenient against errors when deleting (fixes #1860 )
2015-05-24 00:58:46 +01:00
feecdcc7a4
Merge pull request #1854 from calmh/eventmemallocs
...
Reuse a timer instead of allocating a new one in subscription.Poll
2015-05-23 23:23:46 +01:00
29da0bc8f5
Be more lenient against errors when deleting ( fixes #1860 )
2015-05-23 23:57:41 +02:00
7b6b5981c4
UPnP discovery results must not be collected in a background goroutine ( fixes #1858 )
2015-05-23 23:27:02 +02:00
90a1d99785
Reuse a timer instead of allocating a new one in subscription.Poll
...
This is surprisingly memory expensive when Poll gets called a lot, such
as when syncing lots of small files generating itemstarted/itemfinished
events. It's line number three in this heap profile on the
TestBenchmarkManyFiles test:
jb@syno:~/src/github.com/syncthing/syncthing/test (master) $ go tool pprof ../bin/syncthing heap-13194.pprof
Entering interactive mode (type "help" for commands)
(pprof) top
80.91MB of 83.05MB total (97.42%)
Dropped 1024 nodes (cum <= 0.42MB)
Showing top 10 nodes out of 85 (cum >= 1.75MB)
flat flat% sum% cum cum%
32MB 38.53% 38.53% 32.01MB 38.54% github.com/syndtr/goleveldb/leveldb/memdb.New
22.16MB 26.68% 65.21% 22.16MB 26.68% github.com/syndtr/goleveldb/leveldb/util.(*BufferPool).Get
13.02MB 15.68% 80.89% 13.02MB 15.68% time.NewTimer
6.94MB 8.35% 89.24% 6.94MB 8.35% github.com/syndtr/goleveldb/leveldb/memdb.(*DB).Put
3.18MB 3.82% 93.06% 3.18MB 3.82% github.com/calmh/xdr.(*Reader).ReadBytesMaxInto
With this change the allocation is removed entirely.
2015-05-23 20:38:41 +02:00
8dd7e4e6b5
Run benchmarks when running tests
2015-05-23 15:08:17 +02:00
f12b8c19be
Support the creation of top-level folders on Windows ( fixes #1822 )
2015-05-21 19:21:19 +02:00
5042248260
Set permanent UPnP lease when required ( fixes #1831 )
2015-05-21 10:48:40 +02:00
1df6589533
Add status code to SOAP response
2015-05-21 09:54:39 +02:00
f112ef34f6
Don't check interface flags on Windows
2015-05-17 16:42:26 +01:00
e4b57a978f
Translation update
2015-05-15 10:46:47 +02:00
947a129e12
Use updateLocals to ensure event generation
2015-05-14 08:56:42 +02:00
f3fe6a6cbd
Assure existence of a folder marker in the test
2015-05-14 08:46:00 +02:00
9d150bef9f
Refactor GetMtime for early return
2015-05-14 08:26:21 +02:00
65be18cc93
Merge pull request #1804 from cdhowie/virtual-mtimes
...
Implement virtual mtime support for Android
2015-05-14 08:14:29 +02:00
e27ea63900
Add cdhowie
2015-05-14 08:11:02 +02:00
aa96f7b660
Virtual mtime support for environments that don't support altering mtimes ( fixes #831 )
2015-05-13 14:57:29 +00:00
053690d885
Don't attempt reschedule with zero interval
...
Can happen on manual rescans of folders with zero interval.
2015-05-13 16:51:08 +02:00
0b9441e1a4
Reset a namespaced kv-store
2015-05-13 14:41:47 +02:00
c2f2d8771f
Tweak the database block cache size, and add config for it
2015-05-11 09:08:25 +02:00
179c9ee8cc
Merge pull request #1792 from Zillode/tempname
...
Retains part of meaningful filename, added unit test and did a small refactoring
2015-05-10 20:44:55 +02:00
eb8a505287
Merge pull request #1774 from Zillode/fix-rename-windows
...
If rename works we are happy (fixes #1767 )
2015-05-10 19:04:03 +02:00
a7482a3644
Added simple unit test for temporary filenames
2015-05-10 18:57:27 +02:00
a692348336
Retain meaningful names for temporary files
2015-05-10 18:57:27 +02:00
285dcc30cf
Use md5 hash of filename for temporary file ( fixes #1786 )
2015-05-10 18:57:27 +02:00
bcf51aed83
Translation update
2015-05-10 14:59:12 +02:00
f6416285db
If rename works we are happy ( fixes #1767 )
2015-05-10 00:00:24 +02:00
7f0593cd2d
Set default UPnP lease time to 60 minutes
2015-05-09 22:17:53 +02:00
1133192a86
Merge remote-tracking branch 'syncthing/pr/1779'
...
* syncthing/pr/1779:
Remove stray VIM swap file
2015-05-08 20:32:02 +02:00
af3288043a
Remove stray VIM swap file
2015-05-08 16:11:32 +00:00
245bd1eb17
Trigger pull check on remote index updates ( fixes #1765 )
...
Without this, when an index update comes in we only do a new pull if the
remote `localVersion` was increased. But it may not be, because the
index is sent alphabetically and the file with the highest local version
may come first. In that case we'll never do a new pull when the rest of
the index comes in, and we'll be stuck in idle but with lots of out of
sync data.
2015-05-08 10:02:46 +02:00
9308c42cff
Skip boring concurrency test in internal/db
2015-05-07 09:57:49 +02:00
5fc0808f28
Set the execute bit on Windows executables ( fixes #1762 )
2015-05-05 21:45:26 +02:00
e6866ee980
strings.TrimLeft is not actually TrimPrefix
2015-05-05 13:53:11 +02:00
df59bc7194
Merge pull request #1747 from Zillode/fix-1743
...
Partial fix for #1743
2015-05-04 10:51:40 +02:00
1bd85d8baf
Use a channel instead of locks
2015-05-03 14:18:32 +02:00
fe34b08ece
Reschedule the next scan interval ( fixes #1591 )
2015-05-03 12:48:44 +02:00
0ec01f4e78
Distinguish files with same name but different extension in staggered versioner ( fixes #1738 )
2015-05-03 10:36:46 +02:00
d0ebf06ff8
Translation update
2015-05-03 08:29:29 +02:00
687b249034
Don't create stopped folder in staggered versioning ( fixes #1749 )
2015-05-03 08:22:11 +02:00
d1528dcff0
Remove old name conversion from staggered versioning
2015-05-03 08:22:11 +02:00
67f0c9bef0
Do not remove the file when renaming on a case-insensitive platform ( fixes #1743 )
2015-05-01 23:43:45 +02:00
4ff535f883
Twitter link (lazily wrong icon, because not in Glyphicons...)
2015-05-01 23:32:51 +02:00
e3cae69495
Added test for combining case insensitive and negated patterns ( fixes #1678 )
2015-05-01 00:58:44 +02:00
756c5a2604
User fewer hasher routines when there are many folders.
2015-04-29 21:26:08 +02:00
32a76901a9
typos and spelling correction
2015-04-29 15:59:47 +02:00
1207d54fdd
Tweak UPnP discovery, avoid non-multicast interfaces ( fixes #1721 )
2015-04-28 22:32:10 +02:00
f2b12014e1
Merge pull request #1729 from calmh/lint-clean
...
Run vet and lint. Make us lint clean.
2015-04-29 10:16:36 +01:00
60fcaebfdb
Run vet and lint. Make us lint clean.
2015-04-29 10:38:02 +02:00
32fe2cb659
Merge pull request #1700 from calmh/upnpsvc
...
Break out UPnP port mapping into a service
2015-04-29 00:18:49 +01:00
19a2042746
Merge pull request #1723 from calmh/bug-1722
...
Handle conflict with local delete (fixes #1722 )
2015-04-28 10:39:22 +01:00
57ec2ff915
Handle conflict with local delete ( fixes #1722 )
2015-04-28 11:34:16 +02:00
77a161a087
Matcher checks nil receiver
2015-04-28 10:17:14 +01:00
0642402449
Break out UPnP port mapping into a service
2015-04-28 10:25:25 +02:00
fd4ea46fd7
Merge pull request #1708 from jarlebring/upnp_close_conn_fix
...
Fix to for routers that cannot handle many open HTTP-connections
2015-04-26 22:54:47 +02:00
8d8546868d
Fix to for routers that cannot handle many open HTTP-connections
...
Some routers do not respond when too many subsequent SOAP-requests are sent and will generate an EOF-error in the DefaultClient.Do(req). This modification adds a req.Close = True following the description on http://stackoverflow.com/questions/17714494/golang-http-request-results-in-eof-errors-when-making-multiple-requests-successi
2015-04-26 22:31:43 +02:00
8ce547edeb
Fix HTML ( fixes #1707 )
2015-04-26 20:14:34 +01:00
d12db3e7b8
Add osutil.Glob to deal with Windows ( fixes #1690 )
2015-04-26 16:37:50 +01:00
15b87ae297
Merge pull request #1704 from jarlebring/upnp_caps
...
Fix capitalization in HTTP-header in SOAP request (fixes #1696 )
2015-04-26 20:10:14 +09:00
d9da02b7a8
Formatting with gofmt
2015-04-26 12:37:37 +02:00
8f2ad6418d
Fix capitalization in HTTP-header in SOAP request ( fixes #1696 )
...
Some routers are sensitive to the capitalization in "SOAPAction" in the HTTP-header in SOAP request. This modification follows the recommendation of preserving caps in HTTP-headers in go described on http://stackoverflow.com/questions/26351716/how-to-keep-key-case-sensitive-in-request-header-using-golang?lq=1
2015-04-26 12:16:40 +02:00
ac1058359f
Rebuild assets
2015-04-26 00:22:30 +01:00
9afbca3001
Add pagination to Out of sync item list ( fixes #1509 )
2015-04-26 00:22:26 +01:00
be7b3a9952
Configurable file pull order (alphabetic, random, by size or age)
2015-04-25 23:20:21 +09:00
33a4fb5a1a
Fix folder check tests
2015-04-25 23:16:46 +09:00
7bf55dd14f
events.Subscription.Poll does not seem to require locking
...
This is a large source of output from the new lock logging, and it
doesn't seem to accomplish anything useful that I can see. Running
integration with the race detector to make sure...
2015-04-24 11:25:42 +09:00
e158f17c2b
Adjust sync test intervals to be less latency sensitive
2015-04-24 11:25:24 +09:00
36c1d82146
Minor fixup
2015-04-24 09:43:40 +09:00
bd4f404d45
Add tests, fix getCaller, replace wg.Done with wg.Wait
2015-04-23 20:09:14 +01:00
43d39844f7
Merge pull request #1685 from AudriusButkevicius/mut
...
Add mutex logging
2015-04-23 21:16:23 +09:00
Audrius Butkevicius
Jakob Borg
Sergey Mishin
Bart De Vries
Lode Hoste
Chris Howie
Alexander Graf
dartraiden
Elias Jarlebring