63194a37f6
lib/model: Double check results in filepath.Join where needed
...
Wherever we have untrusted relative paths, make sure they are not
escaping their folder root.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3776
2016-12-01 12:35:11 +00:00
cabe94552a
lib/model: Prevent collisions in the progressemitter registry
...
Using filepath.Join can cause collisions. The folder ID could be something
like ".." or "../..".
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3778
2016-12-01 12:34:20 +00:00
48a229a0cd
lib/model: Temp names from all platforms should be recognized as such
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3777
LGTM: AudriusButkevicius
2016-11-30 21:23:24 +00:00
e4db86836b
lib/model: Locking in the request test
2016-11-30 13:11:06 +01:00
913a85c571
lib/model: Add simple file syncing test
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3772
2016-11-30 09:32:28 +00:00
ed4f6fc4b3
lib/connections, lib/model: Connection service should expose a single interface
...
Makes testing easier, which we'll need
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3771
2016-11-30 07:54:20 +00:00
fc1430aa92
lib/fs: The interface and basicfs
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3748
2016-11-24 12:07:14 +00:00
3cde608eda
lib/db: Fix ineffassign lint issue
2016-11-24 12:08:44 +01:00
91568a173a
lib/model: Remove ineffectual assignment in test
2016-11-24 11:33:27 +01:00
e57f5499a1
lib/sync: Remove unused struct field
2016-11-24 11:30:55 +01:00
9abb7b71a9
lib/osutil: Fix lint warning on error formatting ( fixes #3760 )
2016-11-24 11:20:51 +01:00
8559e20237
lib/osutil: Don't chmod in atomic file creation ( fixes #2472 )
...
Instead, trust (and test) that the temp file has appropriate permissions
from the start. The only place where this changes our behavior is for
ignores which go from 0644 to 0600. I'm OK with that.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3756
2016-11-23 14:06:08 +00:00
26730eb083
lib/model: Fix test that relies on ignore reloading
2016-11-23 14:42:29 +01:00
4160ce674d
model: consistently use cfg when referring to config instance and not package
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3755
2016-11-22 23:14:20 +00:00
2dbeea21c4
lib/ignore: Don't slow down tests by sleeping
2016-11-22 22:44:04 +01:00
a2b8485a89
lib/ignore: Fast reload of unchanged ignores ( fixes #3394 )
...
This changes the "seen" map that we're anyway keeping around to track
the modtimes of loaded files instead. When doing a Load() we check that
1) the file we are loading is in the modtime set, and 2) that none of
the files in the modtime set have changed modtimes. If that's the case
we do a quick return without parsing anything or clearing the cache.
This required adding two one seconds sleeps in the tests to make sure
the modtimes were updated when we expect cache reloads, because I'm on a
crappy filesystem with one second timestamp granularity. That also
proves it works...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3754
2016-11-22 21:30:45 +00:00
f1e83a57cd
lib/osutil: Remove unnecessary fsync in Copy()
...
Fsyncing the file has a small performance penalty and seems unnecessary. The
file will be fsynced anyway, when the changes are commited to the database.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3749
2016-11-22 07:59:54 +00:00
cc9a9fb390
lib/model, lib/protocol: Add Folder.Description() for logging (ref #3741 )
2016-11-22 08:36:14 +01:00
d3a251e6d9
lib/model: Log folder IDs and labels ( fixes #3724 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3741
2016-11-21 20:09:18 +01:00
1574b7d834
lib/model: Add fsync of files and directories, option to disable ( fixes #3711 )
2016-11-21 18:09:51 +01:00
548a324256
lib/connections: Slow down failing listeners
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3745
2016-11-19 12:37:14 +00:00
a8a0bc356a
lib/model: Minor cleanup to not fondle cfg.Raw things in handleDeintroductions
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3739
2016-11-17 08:56:55 +00:00
faee1d5a8d
lib/model: Fix locking around introduction handling ( fixes #3737 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3738
2016-11-17 08:50:24 +00:00
3088dac33b
lib/model: Clean up generateClusterConfig, fix spurious test failure by sorting
2016-11-17 07:45:45 +01:00
95c738ea28
lib/protocol: Serialize the all zeroes device ID to the empty string
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3734
2016-11-15 06:22:36 +00:00
38d28c3f4a
lib/relay: Close invitation channel in all error cases ( fixes #3726 )
2016-11-13 09:32:05 +01:00
f60b424d70
lib/config: Raw() -> RawCopy()
2016-11-13 09:29:35 +01:00
a1a91d5ef4
lib/model: Introducer can remove stuff it introduced ( fixes #1015 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3522
2016-11-13 09:29:33 +01:00
59f3d1445f
Revert "lib/model: Introducer can remove stuff it introduced ( fixes #1015 )"
...
This reverts commit 0b88cf1d03
2016-11-12 08:38:29 +01:00
0b88cf1d03
lib/model: Introducer can remove stuff it introduced ( fixes #1015 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3522
2016-11-11 15:54:25 +01:00
56e2ba29d0
lib/config: Subscribers get a copy of the config
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3722
2016-11-11 14:52:23 +00:00
ae4cc94a9d
lib/model: Fix locking order in Availability() ( fixes #3634 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3714
2016-11-08 06:38:50 +00:00
3f9b75b7b3
Revert "lib/model: Introducer can remove stuff it introduced ( fixes #1015 )"
...
This reverts commit ec2b097313
2016-11-08 14:27:32 +08:00
ec2b097313
lib/model: Introducer can remove stuff it introduced ( fixes #1015 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3522
2016-11-08 00:40:48 +08:00
caaab462bc
lib/sync: Fix broken build
2016-11-05 02:31:52 +00:00
da413b823b
lib/sync: Add option for sasha-s/go-deadlock
2016-11-05 02:24:53 +00:00
14937e7dd2
build: Fix proto builder on Windows
2016-11-03 22:06:51 +00:00
3418497f3d
lib/sync: Log everything...
2016-11-03 21:33:33 +00:00
7fba8cf759
lib/sync: Print all lockers, add holder to RWMutex
2016-10-30 00:17:25 +01:00
0296c23685
lib/protocol: Use DeviceID in protocol messages, with custom marshalling
...
This makes the device ID a real type that can be used in the protobuf
schema. That avoids the juggling back and forth from []byte in a bunch
of places and simplifies the code.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3695
2016-10-29 21:56:24 +00:00
74dd051d51
all: Update docs.s.n links to use https
...
Skip-check: authors
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3691
2016-10-27 17:02:19 +00:00
4b3adfa21c
vendor: Update gobwas/glob to fix question mark handling
2016-10-23 15:47:31 +02:00
7c37301c91
lib/ignore: Add directory separator to glob.Compile call
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3674
LGTM: calmh
2016-10-21 07:33:40 +00:00
815588daba
lib/sync, lib/model: Capture locker routine ID, print locker details on deadlock
2016-10-18 21:00:01 +01:00
4e8c8d7e2c
cmd/syncthing, lib/db, lib/model: Track more detailed file/dirs/links/deleted counts
2016-10-17 23:57:43 +02:00
b8a90b7eaa
lib/model: Remove chatty delta index confirmation
...
This had its moment when making sure it worked initially, but nowadays
there is not point discussing the obvious on every folder on every
connect.
2016-10-17 09:21:58 +02:00
05c37e58c1
lib/osutil: Prevent infinite Glob recursion ( fixes #3577 )
...
Skip-check: authors
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3665
2016-10-12 20:55:38 +00:00
fe9c2b9857
lib/ignore: Match directory contents for patterns ending in / ( fixes #3639 )
...
Appends "**" to patterns with a terminal slash, so that directory
contents are ignored, but not the directory itself.
2016-10-04 08:12:55 +09:00
d322ebd0b9
Add API service for local disk changes
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3626
LGTM: calmh, AudriusButkevicius
2016-09-28 15:54:13 +00:00
467c1b26fb
cmd/syncthing, lib/config: Log errors replacing or saving config (ref #3567 )
2016-09-24 09:59:09 +02:00
Jakob Borg
Unrud
Simon Frei
Unrud
Roman Zaynetdinov
Audrius Butkevicius
MikeLund
Benny Ng
Tim Howes
Nathan Morrison