59b1b0e1dc
lib/osutil: Fix "atomic" rename on Windows (ref #6495 , ref #6493 ) ( #6510 )
...
So, in a funny plot twist, it turns out that WriteFile in Go 1.13
doesn't actually set the read only bit on Windows when called with
permissions 0444 so my test was broken. With an improved test it turns
out that Rename does not, in fact, overwrite a read-only file on
Windows. This adds a fix for that.
(Rename might get improved in Go 1.15...)
2020-04-07 15:38:55 +02:00
7505ea79a0
lib/osutil: Don't remove before rename on Windows (ref #6493 ) ( #6495 )
...
This was needed in ancient times but not currently.
2020-04-04 14:17:16 +02:00
4e4b9a872a
lib/dialer: Preserve nilness in error handling ( fixes #6368 ) ( #6369 )
...
Also the call site where it shouldn't anyway be looking at the conn when
the err is non-nil.
2020-02-26 13:16:18 +01:00
eca156fd7f
lib/osutil: Increase maxfiles on macOS properly ( fixes #6206 ) ( #6207 )
2019-12-03 07:26:22 +01:00
1bae4b7f50
all: Use context in lib/dialer ( #6177 )
...
* all: Use context in lib/dialer
* a bit slimmer
* https://github.com/syncthing/syncthing/pull/5753
* bot
* missed adding debug.go
* errors.Cause
* simultaneous dialing
* anti-leak
2019-11-26 07:39:51 +00:00
98a1adebe1
all: Remove dead code, fix lost msgLen checks ( #6129 )
2019-11-06 07:09:58 +01:00
c1c976aa2b
lib/model: Don't panic on failed chmod-back on directory ( fixes #5836 ) ( #5896 )
...
* lib/model: Don't panic on failed chmod-back on directory (fixes #5836 )
This makes the "in writable dir"-wrapper log chmod-back errors instead
of panicking. To do that we need a logger so the function moved into the
model package which is also the only place it's used. The tests came
along.
(The test also exercised osutil.RenameOrCopy like some sort of
piggybacking. I removed that.)
2019-07-28 10:25:05 +02:00
0ca1f26ff8
lib/versioner: Restore for all versioners, cross-device support ( #5514 )
...
* lib/versioner: Restore for all versioners, cross-device support
Fixes #4631
Fixes #4586
Fixes #1634
Fixes #5338
Fixes #5419
2019-04-28 23:30:16 +01:00
c2ddc83509
all: Revert the underscore sillyness
2019-02-02 12:16:27 +01:00
0b2cabbc31
all: Even more boring linter fixes ( #5501 )
2019-02-02 11:45:17 +01:00
272fb3b444
all: Adjust windows perms in fs package ( #5200 )
2018-09-16 16:09:56 +02:00
a2f51c85c2
lib/osutil: Add test for IsDeleted (ref #4925 ) ( #4936 )
2018-05-10 21:39:33 +02:00
eca076cf7d
lib/osutil: Fix TraversesSymlink with symlinked fs root on windows ( fixes #4875 ) ( #4886 )
2018-04-17 22:53:06 +02:00
720e8dedbc
lib/osutil: Use unix lowprio implementation on Android ( #4844 )
2018-03-27 22:03:09 +01:00
5822222c74
lib/model: More precise deletion detection ( fixes #2571 , fixes #4573 ) ( #4765 )
2018-02-25 09:27:54 +01:00
1901a5a9f4
all: Fix typos ( #4772 )
...
Skip-check: authors
2018-02-24 08:51:29 +01:00
8e9c9b9553
lib/osutil: Fix priority lowering on Windows
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4686
2018-01-18 17:03:24 +00:00
3af4164c8b
lib/osutil: Don't attempt to reduce our niceness level ( fixes #4681 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4682
2018-01-18 08:34:56 +00:00
e147db5233
lib/osutil: Check PGID before trying to set it ( fixes #4679 )
...
Fixes "permission denied" return when are already process group /
session leader.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4678
2018-01-17 12:32:11 +00:00
582539a1e6
lib/osutil: Disable setting priority on Windows ( fixes #4676 )
...
Presumably fixing the crash, leaving us to improve this calmly.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4677
2018-01-17 10:14:36 +00:00
c554ffccc9
cmd/syncthing, lib/config, lib/osutil: Lower process priority ( fixes #4628 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4675
2018-01-15 17:11:14 +00:00
429b3a0429
lib/osutil, lib/scanner: Run symlink test on Windows when possible
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4548
2017-11-25 21:49:53 +00:00
7cbd92e1b1
all: Fix comment typos
...
Skip-check: authors
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4481
2017-11-04 07:20:11 +00:00
3d8b4a42b7
all: Convert folders to use filesystem abstraction
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4228
2017-08-19 14:36:56 +00:00
f7fc0c1d3e
all: Update license url to https (ref #3976 )
2017-02-09 08:04:16 +01:00
c4ba580cbb
all: Remove symlink support on Windows, SymlinksEnabled config
...
After this change,
- Symlinks on Windows are always unsupported. Sorry.
- Symlinks are always enabled on other platforms. They are just a small
file like anything else. There is no need to special case them. If you
don't want to sync some symlinks, ignore them.
- The protocol doesn't differentiate between different "types" of
symlinks. If that distinction ever does become relevant the individual
devices can figure it out by looking at the destination when they
create the link.
It's backwards compatible in that all the old symlink types are still
understood to be symlinks, and the new SYMLINK type is equivalent to the
old SYMLINK_UNKNOWN which was always a valid way to do it.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3962
LGTM: AudriusButkevicius
2017-02-07 08:34:24 +00:00
1a1e35d998
lib/osutil: Replace IsDir with TraversesSymlink ( fixes #3839 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3883
LGTM: calmh
2017-01-10 07:09:31 +00:00
f5a310ad64
Revert "lib/model: Handle filename conflicts on Windows."
...
This reverts commit 01e50eb3fa
2016-12-23 11:10:58 +01:00
01e50eb3fa
lib/model: Handle filename conflicts on Windows.
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3810
LGTM: calmh
2016-12-22 23:04:53 +00:00
d41c131364
build: Enable gometalinter "gosimple" check, improve build.go
2016-12-21 14:53:45 +01:00
3582783972
lib/model, lib/osutil: Verify target directory before pulling / requesting
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3798
2016-12-13 10:24:10 +00:00
9abb7b71a9
lib/osutil: Fix lint warning on error formatting ( fixes #3760 )
2016-11-24 11:20:51 +01:00
8559e20237
lib/osutil: Don't chmod in atomic file creation ( fixes #2472 )
...
Instead, trust (and test) that the temp file has appropriate permissions
from the start. The only place where this changes our behavior is for
ignores which go from 0644 to 0600. I'm OK with that.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3756
2016-11-23 14:06:08 +00:00
f1e83a57cd
lib/osutil: Remove unnecessary fsync in Copy()
...
Fsyncing the file has a small performance penalty and seems unnecessary. The
file will be fsynced anyway, when the changes are commited to the database.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3749
2016-11-22 07:59:54 +00:00
1574b7d834
lib/model: Add fsync of files and directories, option to disable ( fixes #3711 )
2016-11-21 18:09:51 +01:00
05c37e58c1
lib/osutil: Prevent infinite Glob recursion ( fixes #3577 )
...
Skip-check: authors
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3665
2016-10-12 20:55:38 +00:00
18cc7a663b
lib: Remove osutil.Remove & osutil.RemoveAll ( fixes #3513 )
...
These are no longer required with Go 1.7. Change made by removing the
functions, doing a global s/osutil.Remove/os.Remove/.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3514
2016-08-16 10:01:58 +00:00
502bee9a09
lib/osutil: Return "/" as filesystem root on non-windows ( fixes #3321 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3332
2016-06-20 20:25:00 +00:00
1612baca92
gui: /rest/system/browse with no arguments returns drives on Windows (ref #3201 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3203
2016-05-31 19:27:07 +00:00
242db26343
lib/osutil: Fix globbing at root ( fixes #3201 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3202
2016-05-28 04:13:34 +00:00
915e1ac7de
lib/model: Handle (?d) deletes of directories ( fixes #3164 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3170
2016-05-23 23:32:08 +00:00
6e07742fe9
gui, lib: Add missing licenses ( fixes #3100 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3108
2016-05-18 00:10:50 +00:00
bd41e21c26
all: Correct spelling in comments
...
Skip-check: authors pr-build-mac
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3056
2016-05-08 10:54:22 +00:00
1c7af1a72e
lib/upnp: Fix port order
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/2980
2016-04-16 22:44:07 +00:00
a8ffde6f21
Add deps
2016-03-06 20:32:10 +00:00
f59e1ad854
Use dialer in relay checks ( fixes #2732 )
2016-01-30 12:33:42 +00:00
82e033942e
RLimit comment typo
...
Thanks @plouj
2016-01-17 12:54:44 +01:00
cec87be4e3
Remove windows specialisation from osutil.GetLans ( fixes #2192 )
2015-12-20 18:10:02 +00:00
f062e35641
Don't chmod in Atomic on android (fixes #2472 )
2015-11-28 02:46:06 +10:00
be2ca0ea22
Revert "Case insensitive renames, part 1"
2015-09-30 21:40:04 +02:00
Jakob Borg
Paul Brit
Simon Frei
Audrius Butkevicius
Audrius Butkevicius
Matic Potočnik
Unrud
Unrud
Benny Ng
Jakob Borg
aviau
klemens
Lode Hoste
kluppy