From 7e45b5504c66d29b77c16f59dc4f8f0de72145ba Mon Sep 17 00:00:00 2001 From: Adam Kwolek Date: Tue, 14 Jun 2011 12:48:53 +1000 Subject: [PATCH] imsm: Fix: klocwork: targets variable can be used uninitialized When target_offsets allocation fails execution goes to abort label, where elements from targets table are closed. Initialize targets table after allocation. Signed-off-by: Adam Kwolek Signed-off-by: NeilBrown --- super-intel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/super-intel.c b/super-intel.c index 7190f51..6c74e50 100644 --- a/super-intel.c +++ b/super-intel.c @@ -7716,13 +7716,15 @@ int save_backup_imsm(struct supertype *st, if (!targets) goto abort; + for (i = 0; i < new_disks; i++) + targets[i] = -1; + target_offsets = malloc(new_disks * sizeof(unsigned long long)); if (!target_offsets) goto abort; start = info->reshape_progress * 512; for (i = 0; i < new_disks; i++) { - targets[i] = -1; target_offsets[i] = (unsigned long long) __le32_to_cpu(super->migr_rec->ckpt_area_pba) * 512; /* move back copy area adderss, it will be moved forward