Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

DDF: remove an old incorrect FIXME comment. 

We mustn't close fds in write_init_super if ->update_tail
was set.

Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
NeilBrown 2014-05-21 13:00:08 +10:00
parent 31bc5466f5
commit 733eedc8f2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
super-ddf.c
View File

@ -3259,13 +3259,15 @@ static int write_init_super_ddf(struct supertype *st)
len); len);
append_metadata_update(st, vc, tlen); append_metadata_update(st, vc, tlen);
/* FIXME I need to close the fds! */
return 0; return 0;
} else { } else {
struct dl *d; struct dl *d;
if (!currentconf) if (!currentconf)
for (d = ddf->dlist; d; d=d->next) for (d = ddf->dlist; d; d=d->next)
while (Kill(d->devname, NULL, 0, -1, 1) == 0); while (Kill(d->devname, NULL, 0, -1, 1) == 0);
/* Note: we don't close the fd's now, but a subsequent
* ->free_super() will
*/
return __write_init_super_ddf(st); return __write_init_super_ddf(st);
} }
} }