Manage: fixed some error message in --stop
Explain the meaning of 'quiet' explicitly, and fix some grammar and formatting. Signed-off-by: Neil Brown <neilb@suse.de>
This commit is contained in:
parent
9fe3204317
commit
4b9d39fc17
17
Manage.c
17
Manage.c
|
@ -78,13 +78,18 @@ int Manage_runstop(char *devname, int fd, int runstop, int quiet)
|
||||||
{
|
{
|
||||||
/* Run or stop the array. array must already be configured
|
/* Run or stop the array. array must already be configured
|
||||||
* required >= 0.90.0
|
* required >= 0.90.0
|
||||||
|
* Only print failure messages if quiet == 0;
|
||||||
|
* quiet > 0 means really be quiet
|
||||||
|
* quiet < 0 means we will try again if it fails.
|
||||||
*/
|
*/
|
||||||
mdu_param_t param; /* unused */
|
mdu_param_t param; /* unused */
|
||||||
|
|
||||||
if (runstop == -1 && md_get_version(fd) < 9000) {
|
if (runstop == -1 && md_get_version(fd) < 9000) {
|
||||||
if (ioctl(fd, STOP_MD, 0)) {
|
if (ioctl(fd, STOP_MD, 0)) {
|
||||||
if (!quiet) fprintf(stderr, Name ": stopping device %s failed: %s\n",
|
if (quiet == 0) fprintf(stderr,
|
||||||
devname, strerror(errno));
|
Name ": stopping device %s "
|
||||||
|
"failed: %s\n",
|
||||||
|
devname, strerror(errno));
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -125,9 +130,9 @@ int Manage_runstop(char *devname, int fd, int runstop, int quiet)
|
||||||
close(fd);
|
close(fd);
|
||||||
if (sysfs_set_str(mdi, NULL,
|
if (sysfs_set_str(mdi, NULL,
|
||||||
"array_state", "inactive") < 0) {
|
"array_state", "inactive") < 0) {
|
||||||
if (quiet==0)
|
if (quiet == 0)
|
||||||
fprintf(stderr, Name
|
fprintf(stderr, Name
|
||||||
": fail to stop array %s: %s\n",
|
": failed to stop array %s: %s\n",
|
||||||
devname, strerror(errno));
|
devname, strerror(errno));
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
@ -144,9 +149,9 @@ int Manage_runstop(char *devname, int fd, int runstop, int quiet)
|
||||||
sysfs_free(mdi);
|
sysfs_free(mdi);
|
||||||
|
|
||||||
if (fd >= 0 && ioctl(fd, STOP_ARRAY, NULL)) {
|
if (fd >= 0 && ioctl(fd, STOP_ARRAY, NULL)) {
|
||||||
if (quiet==0)
|
if (quiet == 0)
|
||||||
fprintf(stderr, Name
|
fprintf(stderr, Name
|
||||||
": fail to stop array %s: %s\n",
|
": failed to stop array %s: %s\n",
|
||||||
devname, strerror(errno));
|
devname, strerror(errno));
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue