Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: ensure mpb buffer is zeroed 

Don't leak unitialized data into the mpb.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams 2009-04-12 00:58:27 -07:00
parent 9d84c8eac2
commit 1f45a8ad20
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
super-intel.c
View File

@ -1746,7 +1746,8 @@ static int parse_raid_devices(struct intel_super *super)
if (posix_memalign(&buf, 512, len) != 0)
return 1;
memcpy(buf, super->buf, len);
memcpy(buf, super->buf, super->len);
memset(buf + super->len, 0, len - super->len);
free(super->buf);
super->buf = buf;
super->len = len;
@ -4382,7 +4383,9 @@ static void imsm_prepare_update(struct supertype *st,
free(super->next_buf);
super->next_len = buf_len;
if (posix_memalign(&super->next_buf, 512, buf_len) != 0)
if (posix_memalign(&super->next_buf, 512, buf_len) == 0)
memset(super->next_buf, 0, buf_len);
else
super->next_buf = NULL;
}
}