e87f788dce
Prevent multiple heap allocations in MatroskaEditionEntry::label()
2018-06-02 23:05:04 +02:00
b665d2557a
Fix missing break in MatroskaChapter::internalParse()
2018-06-02 23:05:04 +02:00
0a640c9f7f
Fix warnings, mostly about implicit int conversions
...
This should fix all non-erros, leaving only warnings which
are indeed potential problems.
The following warnings should be safe to ignore:
* Conversions of various offsets from uint64 to
std::streamoff/int64 are safe because such offsets have
been obtained via tellg() and other functions
returning std::streamoff in the first place.
* It also works vice-versa since tellg() should not
return negative offsets with exceptions enabled.
* Conversions from char to unsigned char are also ok.
* Unused diag arguments can be ignored (those might be
useful later).
* Annotate all intended fallthoughs.
2018-06-02 23:04:53 +02:00
404e4f751f
Improve comments and accessing the value in Id3v2FrameMaker
2018-06-02 19:34:07 +02:00
710b7b420a
Prevent writing float/e-notation to Id3v2 duration field
2018-06-02 19:31:39 +02:00
878b3a3c4e
Make diag msg on conversion error in Id3v2FrameMaker more specific
2018-06-02 19:29:43 +02:00
ba23b49d39
Ensure iostream is included in id3v2tag.cpp
2018-06-02 19:27:29 +02:00
f1656faa96
Fix TagValue::to{TimeSpan,DateTime}() for UTF-16
2018-06-02 19:23:07 +02:00
09c1c6a232
Improve coding style in TagValue
2018-06-02 19:22:26 +02:00
fd1864c3df
Make error messages in TagValue more specific
2018-06-02 19:21:15 +02:00
bf7428d066
Fix warnings, improve coding style
2018-05-31 00:25:32 +02:00
a3bf8267ac
Fix treating short and long ID3v2 frame IDs as equal
2018-05-31 00:25:06 +02:00
047e9f7fd0
ID3v2: Warn if specified string is no valid position
2018-05-31 00:23:01 +02:00
38da0c796b
ID1v1: Allow conversion from int/string to position
2018-05-31 00:21:54 +02:00
221409fdcf
Make Vorbis Comments consistently case insensitive
2018-05-13 20:41:26 +02:00
8887ae81cf
Don't use exception in MatroskaTag::internallyGetKnownField()
2018-05-13 20:40:30 +02:00
2431889b64
Apply clang-format
2018-05-13 00:25:14 +02:00
c377524850
Fix FieldMapBasedTag<ImplementationType>::knownField()
2018-05-13 00:25:02 +02:00
7d65a91900
Update patch version
2018-05-08 18:47:03 +02:00
62999e0be6
Fix usage of enable_if with GCC 8
...
Seems like the trick with the three dots isn't working
with GCC 8 anymore. So let's make it a default template
parameter then.
Not sure whether GCC 8 is here correct and whether this
workaround causes further trouble.
2018-05-07 23:52:38 +02:00
b58eac9302
Use CPPUNIT_ASSERT_EQUAL in tests where possible
2018-04-30 19:00:22 +02:00
e29f9bd4f8
Fix warnings in MediaFileInfo, make safe casts explicit
2018-04-30 19:00:02 +02:00
1889afef8f
Take over track parsing status when parsing FLAC tags
2018-04-30 18:59:17 +02:00
9cbc708a56
Apply clang-format
2018-04-29 21:15:34 +02:00
ce4bd73037
Fix setting "isLast" flag when making FLAC header
2018-04-29 21:14:28 +02:00
01a0c730ba
Make operators for VorbisCommentFlags constexpr
2018-04-29 21:14:02 +02:00
388945d2b4
Add diag message when padding not supported
2018-04-29 21:13:30 +02:00
9b83cc37f6
Handle case when Vorbis Comment exceeds max. size in FLAC stream
2018-04-29 19:45:20 +02:00
30553c947c
Fix warnings and improve style in makeMp3File()
2018-04-29 18:58:41 +02:00
ae65ad0408
Fix removing tags from FLAC files
2018-04-29 18:17:24 +02:00
96010768f0
Improve documentation in MediaFileInfo
2018-04-29 18:11:15 +02:00
b76c334606
Apply clang-format
2018-04-29 17:19:33 +02:00
0f0260fb77
Fix parseTags() for FLAC, consider tags unsupported if container unknown
...
FLAC stores tags on track level. Hence we must parse the
tracks here in order to parse the tags. This hasn't been taken
into account when refactoring the tag editor CLI leading to
https://github.com/Martchus/tageditor/issues/36 .
So let's handle these format specific details in the tagparser
library which will now internally parse tracks when calling
parseTags() on FLAC files.
This also fixes the weird behavior to consider tags supported
although the container format is unknown.
2018-04-29 17:18:17 +02:00
d856fb4c75
Use std::numeric_limits
2018-03-21 20:40:51 +01:00
20b4cc833f
Reorder enums
2018-03-21 20:31:29 +01:00
f5bd1dc4e8
Use unsigned int as underlying type for enums
2018-03-21 20:30:51 +01:00
cbb54d5aeb
Allow custom writing application
2018-03-20 21:41:05 +01:00
3e85eba00f
Apply clang-format
2018-03-14 17:56:37 +01:00
281d3e7952
Workaround GGC bug 66297
2018-03-13 22:06:32 +01:00
ca0b8e4d8c
Improve coding style
2018-03-11 22:28:15 +01:00
706c410edb
Clear description encoding of TagValue
2018-03-11 22:27:55 +01:00
59024a66a0
Don't clear field before parsing by default
2018-03-11 22:27:12 +01:00
8d91886b14
Improve test output for TagValues
2018-03-11 22:24:57 +01:00
ed9939dc74
Support 'file://' protocol prefix
2018-03-11 19:15:13 +01:00
b47705ff81
Refactor MediaFileInfo::createAppropriateTags()
2018-03-11 18:57:22 +01:00
dabd18102e
Remove out-commented code for nested tags
2018-03-11 16:15:46 +01:00
b35fc2ff0d
Improve some structure layouts
2018-03-11 16:14:42 +01:00
0215b89057
Improve Id3v2Frame
2018-03-11 16:03:22 +01:00
a26b98dcd7
Improve TagValue
...
* Make more functions inline
* Fix use of std::size_t
2018-03-11 15:16:09 +01:00
c0336ed4bb
Apply clang-format
2018-03-07 01:17:50 +01:00