Martchus
/
syncthingtray
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,533 Commits 17 Branches 88 Tags 19 MiB
Commit Graph

15 Commits

Author SHA1 Message Date
Martchus 722e9f6e7d Avoid greeting new users with "insufficient configuration" error 2022-10-02 19:45:22 +02:00
Martchus be9d963a82 Add internal errors to menu/dialog even if the notification is disabled 2022-05-04 00:24:26 +02:00
Martchus 8b273b6945 Improve messages for TLS errors 
Before one only gets the generic error "TLS handshake failed". Now one gets
more details error messages plus the problematic certificate. This should
be helpful for debugging.
 2021-10-07 18:22:41 +02:00
Martchus 8348648c56 Make c'tor of `InternalError` inline again to workaround linker errors 
Otherwise the shared build with targeting x86_64-w64-mingw32 fails with:

```
FAILED: widgets/syncthingwidgets-qt6.dll widgets/libsyncthingwidgets-qt6.dll.a
: && /usr/lib/ccache/bin/x86_64-w64-mingw32-g++ -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS  -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS -O2 -pipe -fno-plt -fexceptions --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fcf-protection -O3 -DNDEBUG  -Wl,-O1,--sort-common,--as-needed -fstack-protector -shared -o widgets/syncthingwidgets-qt6.dll -Wl,--out-implib,widgets/libsyncthingwidgets-qt6.dll.a -Wl,--major-image-version,1,--minor-image-version,1 widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/mocs_compilation.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/settings/settings.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/settings/settingsdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/webview/webpage.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/webview/webviewdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/webview/webviewinterceptor.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/textviewdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerrorsdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/direrrorsdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/statusinfo.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/dbusstatusnotifier.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerror.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/otherdialogs.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/syncthinglauncher.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/syncthingkiller.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/resources/windows-Release.rc.res widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/3YJK5W5UP7/qrc_syncthingwidgetsicons.cpp.obj -L/build/mingw-w64-syncthingtray-qt6/src/syncthingtray/build-x86_64-w64-mingw32-shared/connector   -L/build/mingw-w64-syncthingtray-qt6/src/syncthingtray/build-x86_64-w64-mingw32-shared/model   -L/build/mingw-w64-syncthingtray-qt6/src/lib model/libsyncthingmodel-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libqtutilities-qt6.dll.a  libsyncthing/libsyncthing-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Network.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Concurrent.dll.a  connector/libsyncthingconnector-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libc++utilities.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Network.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Core.dll.a  /usr/x86_64-w64-mingw32/lib/libqtforkawesome-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Widgets.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Gui.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Core.dll.a  /usr/x86_64-w64-mingw32/lib/libc++utilities.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Widgets.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Gui.dll.a  -ld3d11  -ldxgi  -ldxguid  -lws2_32  /usr/x86_64-w64-mingw32/lib/libQt6Core.dll.a  -lmpr  -luserenv  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && :
/usr/lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld: widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerror.cpp.obj:internalerror.cpp:(.text+0x1a0): multiple definition of `QtGui::InternalError::InternalError(QString const&, QUrl const&, QByteArray const&)'; widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/mocs_compilation.cpp.obj:mocs_compilation.cpp:(.text$_ZN5QtGui13InternalErrorC2ERK7QStringRK4QUrlRK10QByteArray[_ZN5QtGui13InternalErrorC2ERK7QStringRK4QUrlRK10QByteArray]+0x0): first defined here
/usr/lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld: widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerror.cpp.obj:internalerror.cpp:(.text+0x1a0): multiple definition of `QtGui::InternalError::InternalError(QString const&, QUrl const&, QByteArray const&)'; widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/mocs_compilation.cpp.obj:mocs_compilation.cpp:(.text$_ZN5QtGui13InternalErrorC1ERK7QStringRK4QUrlRK10QByteArray[_ZN5QtGui13InternalErrorC1ERK7QStringRK4QUrlRK10QByteArray]+0x0): first defined here
```

I can currently not make sense of this build error. It does not happen
when targeting Linux or i686.
 2021-10-05 00:13:34 +02:00
Martchus 745082f357 Redact password from URL when displaying internal errors 2021-10-02 20:31:20 +02:00
Martchus 975e86c895 Allow backend libraries to be used from other projects 
So far the backend libraries' include paths were relative within this
repository. This means the header files could not be used at their
installed location.

This change replaces them with "<>" includes to fix that problem and adds
a new include directory so building everything at once still works.

With this change it should be easier to actually split some parts into
another repository if this one would become too big.
 2021-01-25 19:48:11 +01:00
Martchus a18ade7a36 Consider more error types when ignoring disconnects 
See
https://github.com/Martchus/syncthingtray/issues/79#issuecomment-716136144
 2020-10-26 17:39:10 +01:00
Martchus a30853cfeb Apply cmake-format and clang-format 2019-05-04 22:10:37 +02:00
Martchus f8dabbc78d Fix compilation without systemd support 2018-05-10 13:51:25 +02:00
Martchus 0ceb8d5e79 Add high-level abstraction for launching Syncthing 
Add new SyncthingLauncher class which lauches Syncthing
under the hood via external SyncthingProcess or using
libsyncthing.

Note: Launching via libsyncthing is still experimental.
 2018-04-11 23:16:00 +02:00
Martchus d08aa005d7 Fix compilation without systemd support 2018-04-10 21:05:49 +02:00
Martchus ce7a4421fa Consider isActiveFor() for process also when systemd unavailable 2018-04-02 20:52:50 +02:00
Martchus 146d4870e4 Refactor preventing unwanted error messages 
* See https://github.com/Martchus/syncthingtray/issues/15
* Not tested yet
 2018-04-02 20:35:30 +02:00
Martchus 69ffaeb1f3 Apply tidy after updating to clang-format 5.0.0 
The behavior of clang-format slightly changed in Clang 5.0.0:
http://releases.llvm.org/5.0.0/tools/clang/docs/ReleaseNotes.html#clang-format
 2017-09-17 21:48:15 +02:00
Martchus 5046cb3eed Move logic for determine error relevance to InternalError 2017-09-08 17:01:51 +02:00