// Copyright (C) 2016 The Syncthing Authors. // // This Source Code Form is subject to the terms of the Mozilla Public // License, v. 2.0. If a copy of the MPL was not distributed with this file, // You can obtain one at https://mozilla.org/MPL/2.0/. package model import ( "bytes" "io/ioutil" "os" "path/filepath" "runtime" "strings" "testing" "time" "github.com/syncthing/syncthing/lib/config" "github.com/syncthing/syncthing/lib/db" "github.com/syncthing/syncthing/lib/fs" "github.com/syncthing/syncthing/lib/protocol" ) func TestRequestSimple(t *testing.T) { // Verify that the model performs a request and creates a file based on // an incoming index update. m, fc, tmpFolder := setupModelWithConnection() defer m.Stop() defer os.RemoveAll(tmpFolder) // We listen for incoming index updates and trigger when we see one for // the expected test file. done := make(chan struct{}) fc.mut.Lock() fc.indexFn = func(folder string, fs []protocol.FileInfo) { for _, f := range fs { if f.Name == "testfile" { close(done) return } } } fc.mut.Unlock() // Send an update for the test file, wait for it to sync and be reported back. contents := []byte("test file contents\n") fc.addFile("testfile", 0644, protocol.FileInfoTypeFile, contents) fc.sendIndexUpdate() <-done // Verify the contents bs, err := ioutil.ReadFile(filepath.Join(tmpFolder, "testfile")) if err != nil { t.Error("File did not sync correctly:", err) return } if !bytes.Equal(bs, contents) { t.Error("File did not sync correctly: incorrect data") } } func TestSymlinkTraversalRead(t *testing.T) { // Verify that a symlink can not be traversed for reading. if runtime.GOOS == "windows" { t.Skip("no symlink support on CI") return } m, fc, tmpFolder := setupModelWithConnection() defer m.Stop() defer os.RemoveAll(tmpFolder) // We listen for incoming index updates and trigger when we see one for // the expected test file. done := make(chan struct{}) fc.mut.Lock() fc.indexFn = func(folder string, fs []protocol.FileInfo) { for _, f := range fs { if f.Name == "symlink" { close(done) return } } } fc.mut.Unlock() // Send an update for the symlink, wait for it to sync and be reported back. contents := []byte("..") fc.addFile("symlink", 0644, protocol.FileInfoTypeSymlink, contents) fc.sendIndexUpdate() <-done // Request a file by traversing the symlink buf := make([]byte, 10) err := m.Request(device1, "default", "symlink/requests_test.go", 0, nil, false, buf) if err == nil || !bytes.Equal(buf, make([]byte, 10)) { t.Error("Managed to traverse symlink") } } func TestSymlinkTraversalWrite(t *testing.T) { // Verify that a symlink can not be traversed for writing. if runtime.GOOS == "windows" { t.Skip("no symlink support on CI") return } m, fc, tmpFolder := setupModelWithConnection() defer m.Stop() defer os.RemoveAll(tmpFolder) // We listen for incoming index updates and trigger when we see one for // the expected names. done := make(chan struct{}, 1) badReq := make(chan string, 1) badIdx := make(chan string, 1) fc.mut.Lock() fc.indexFn = func(folder string, fs []protocol.FileInfo) { for _, f := range fs { if f.Name == "symlink" { done <- struct{}{} return } if strings.HasPrefix(f.Name, "symlink") { badIdx <- f.Name return } } } fc.requestFn = func(folder, name string, offset int64, size int, hash []byte, fromTemporary bool) ([]byte, error) { if name != "symlink" && strings.HasPrefix(name, "symlink") { badReq <- name } return fc.fileData[name], nil } fc.mut.Unlock() // Send an update for the symlink, wait for it to sync and be reported back. contents := []byte("..") fc.addFile("symlink", 0644, protocol.FileInfoTypeSymlink, contents) fc.sendIndexUpdate() <-done // Send an update for things behind the symlink, wait for requests for // blocks for any of them to come back, or index entries. Hopefully none // of that should happen. contents = []byte("testdata testdata\n") fc.addFile("symlink/testfile", 0644, protocol.FileInfoTypeFile, contents) fc.addFile("symlink/testdir", 0644, protocol.FileInfoTypeDirectory, contents) fc.addFile("symlink/testsyml", 0644, protocol.FileInfoTypeSymlink, contents) fc.sendIndexUpdate() select { case name := <-badReq: t.Fatal("Should not have requested the data for", name) case name := <-badIdx: t.Fatal("Should not have sent the index entry for", name) case <-time.After(3 * time.Second): // Unfortunately not much else to trigger on here. The puller sleep // interval is 1s so if we didn't get any requests within two // iterations we should be fine. } } func TestRequestCreateTmpSymlink(t *testing.T) { // Test that an update for a temporary file is invalidated m, fc, tmpFolder := setupModelWithConnection() defer m.Stop() defer os.RemoveAll(tmpFolder) // We listen for incoming index updates and trigger when we see one for // the expected test file. goodIdx := make(chan struct{}) name := fs.TempName("testlink") fc.mut.Lock() fc.indexFn = func(folder string, fs []protocol.FileInfo) { for _, f := range fs { if f.Name == name { if f.Invalid { goodIdx <- struct{}{} } else { t.Fatal("Received index with non-invalid temporary file") } return } } } fc.mut.Unlock() // Send an update for the test file, wait for it to sync and be reported back. fc.addFile(name, 0644, protocol.FileInfoTypeSymlink, []byte("..")) fc.sendIndexUpdate() select { case <-goodIdx: case <-time.After(3 * time.Second): t.Fatal("Timed out without index entry being sent") } } func TestRequestVersioningSymlinkAttack(t *testing.T) { if runtime.GOOS == "windows" { t.Skip("no symlink support on Windows") } // Sets up a folder with trashcan versioning and tries to use a // deleted symlink to escape tmpFolder, err := ioutil.TempDir(".", "_request-") if err != nil { panic("Failed to create temporary testing dir") } cfg := defaultConfig.RawCopy() cfg.Folders[0] = config.NewFolderConfiguration("default", fs.FilesystemTypeBasic, tmpFolder) cfg.Folders[0].Devices = []config.FolderDeviceConfiguration{ {DeviceID: device1}, {DeviceID: device2}, } cfg.Folders[0].Versioning = config.VersioningConfiguration{ Type: "trashcan", } w := config.Wrap("/tmp/cfg", cfg) db := db.OpenMemory() m := NewModel(w, device1, "syncthing", "dev", db, nil) m.AddFolder(cfg.Folders[0]) m.ServeBackground() m.StartFolder("default") defer m.Stop() defer os.RemoveAll(tmpFolder) fc := addFakeConn(m, device2) fc.folder = "default" // Create a temporary directory that we will use as target to see if // we can escape to it tmpdir, err := ioutil.TempDir("", "syncthing-test") if err != nil { t.Fatal(err) } // We listen for incoming index updates and trigger when we see one for // the expected test file. idx := make(chan int) fc.mut.Lock() fc.indexFn = func(folder string, fs []protocol.FileInfo) { idx <- len(fs) } fc.mut.Unlock() // Send an update for the test file, wait for it to sync and be reported back. fc.addFile("foo", 0644, protocol.FileInfoTypeSymlink, []byte(tmpdir)) fc.sendIndexUpdate() for updates := 0; updates < 1; updates += <-idx { } // Delete the symlink, hoping for it to get versioned fc.deleteFile("foo") fc.sendIndexUpdate() for updates := 0; updates < 1; updates += <-idx { } // Recreate foo and a file in it with some data fc.addFile("foo", 0755, protocol.FileInfoTypeDirectory, nil) fc.addFile("foo/test", 0644, protocol.FileInfoTypeFile, []byte("testtesttest")) fc.sendIndexUpdate() for updates := 0; updates < 1; updates += <-idx { } // Remove the test file and see if it escaped fc.deleteFile("foo/test") fc.sendIndexUpdate() for updates := 0; updates < 1; updates += <-idx { } path := filepath.Join(tmpdir, "test") if _, err := os.Lstat(path); !os.IsNotExist(err) { t.Fatal("File escaped to", path) } } func setupModelWithConnection() (*Model, *fakeConnection, string) { tmpFolder, err := ioutil.TempDir(".", "_request-") if err != nil { panic("Failed to create temporary testing dir") } cfg := defaultConfig.RawCopy() cfg.Folders[0] = config.NewFolderConfiguration("default", fs.FilesystemTypeBasic, tmpFolder) cfg.Folders[0].Devices = []config.FolderDeviceConfiguration{ {DeviceID: device1}, {DeviceID: device2}, } w := config.Wrap("/tmp/cfg", cfg) db := db.OpenMemory() m := NewModel(w, device1, "syncthing", "dev", db, nil) m.AddFolder(cfg.Folders[0]) m.ServeBackground() m.StartFolder("default") fc := addFakeConn(m, device2) fc.folder = "default" return m, fc, tmpFolder }