diff --git a/src/Draw.cpp b/src/Draw.cpp index d693450..18ad1ca 100644 --- a/src/Draw.cpp +++ b/src/Draw.cpp @@ -314,7 +314,7 @@ void CDraw::drawNoteName(int midiNote, float x, float y, int type) if(0getFluidSoundFontNames().size()==0){ - m_settings->remove("FluidSynth"); + m_settings->remove(QStringLiteral("FluidSynth")); }else{ - m_settings->setValue("FluidSynth/masterGainSpin",masterGainSpin->value()); - m_settings->setValue("FluidSynth/bufferSizeCombo", bufferSizeCombo->currentText()); - m_settings->setValue("FluidSynth/bufferCountCombo", bufferCountCombo->currentText()); - m_settings->setValue("FluidSynth/reverbCheck",reverbCheck->isChecked()); - m_settings->setValue("FluidSynth/chorusCheck",chorusCheck->isChecked()); - m_settings->setValue("FluidSynth/audioDriverCombo",audioDriverCombo->currentText()); - m_settings->setValue("FluidSynth/sampleRateCombo",sampleRateCombo->currentText()); + m_settings->setValue(QStringLiteral("FluidSynth/masterGainSpin"),masterGainSpin->value()); + m_settings->setValue(QStringLiteral("FluidSynth/bufferSizeCombo"), bufferSizeCombo->currentText()); + m_settings->setValue(QStringLiteral("FluidSynth/bufferCountCombo"), bufferCountCombo->currentText()); + m_settings->setValue(QStringLiteral("FluidSynth/reverbCheck"),reverbCheck->isChecked()); + m_settings->setValue(QStringLiteral("FluidSynth/chorusCheck"),chorusCheck->isChecked()); + m_settings->setValue(QStringLiteral("FluidSynth/audioDriverCombo"),audioDriverCombo->currentText()); + m_settings->setValue(QStringLiteral("FluidSynth/sampleRateCombo"),sampleRateCombo->currentText()); } m_settings->saveSoundFontSettings(); @@ -218,14 +218,14 @@ void GuiMidiSetupDialog::accept() if (midiInputCombo->currentText().startsWith(tr("None"))) CChord::setPianoRange(PC_KEY_LOWEST_NOTE, PC_KEY_HIGHEST_NOTE); else - CChord::setPianoRange(m_settings->value("Keyboard/LowestNote", 0).toInt(), - m_settings->value("Keyboard/HighestNote", 127).toInt()); + CChord::setPianoRange(m_settings->value(QStringLiteral("Keyboard/LowestNote"), 0).toInt(), + m_settings->value(QStringLiteral("Keyboard/HighestNote"), 127).toInt()); if (midiOutputCombo->currentIndex()==0){ - m_settings->setValue("Midi/Output", ""); - m_song->openMidiPort(CMidiDevice::MIDI_OUTPUT,""); + m_settings->setValue(QStringLiteral("Midi/Output"), QString()); + m_song->openMidiPort(CMidiDevice::MIDI_OUTPUT, QString()); }else{ - m_settings->setValue("Midi/Output", midiOutputCombo->currentText()); + m_settings->setValue(QStringLiteral("Midi/Output"), midiOutputCombo->currentText()); m_song->openMidiPort(CMidiDevice::MIDI_OUTPUT, midiOutputCombo->currentText() ); } m_settings->updateWarningMessages(); @@ -237,16 +237,16 @@ void GuiMidiSetupDialog::accept() { if( m_latencyFix> 0) { - int rightSound = m_settings->value("Keyboard/RightSound", Cfg::defaultRightPatch()).toInt(); - m_settings->setValue("Keyboard/RightSoundPrevious", rightSound); // Save the current right sound + int rightSound = m_settings->value(QStringLiteral("Keyboard/RightSound"), Cfg::defaultRightPatch()).toInt(); + m_settings->setValue(QStringLiteral("Keyboard/RightSoundPrevious"), rightSound); // Save the current right sound // Mute the Piano if we are using the latency fix; - m_settings->setValue("Keyboard/RightSound", 0); + m_settings->setValue(QStringLiteral("Keyboard/RightSound"), 0); m_song->setPianoSoundPatches( -1, -2); // -1 means no sound and -2 means ignore this parameter } else { - int previousRightSound = m_settings->value("Keyboard/RightSoundPrevious", Cfg::defaultRightPatch()).toInt(); - m_settings->setValue("Keyboard/RightSound", previousRightSound); + int previousRightSound = m_settings->value(QStringLiteral("Keyboard/RightSoundPrevious"), Cfg::defaultRightPatch()).toInt(); + m_settings->setValue(QStringLiteral("Keyboard/RightSound"), previousRightSound); m_song->setPianoSoundPatches(previousRightSound, -2); // -2 means ignore this parameter } m_latencyChanged = false; @@ -280,7 +280,7 @@ void GuiMidiSetupDialog::on_fluidLoadButton_clicked ( bool checked ) { Q_UNUSED(checked) #if WITH_INTERNAL_FLUIDSYNTH - QString lastSoundFont = m_settings->value("LastSoundFontDir","").toString(); + QString lastSoundFont = m_settings->value(QStringLiteral("LastSoundFontDir"), QString()).toString(); if (lastSoundFont.isEmpty()) { diff --git a/src/GuiTopBar.cpp b/src/GuiTopBar.cpp index 69a194c..d1c4f51 100644 --- a/src/GuiTopBar.cpp +++ b/src/GuiTopBar.cpp @@ -165,8 +165,8 @@ void GuiTopBar::setPlayButtonState(bool checked, bool atTheEnd) if (checked) { playButton->setIcon(QIcon(QStringLiteral(":/images/breeze/media-playback-stop.svg"))); - playButton->setToolTip(""); - playFromStartButton->setToolTip(""); + playButton->setToolTip(QString()); + playFromStartButton->setToolTip(QString()); } else { diff --git a/src/Settings.h b/src/Settings.h index be07857..4845b98 100644 --- a/src/Settings.h +++ b/src/Settings.h @@ -149,7 +149,7 @@ public: void updateWarningMessages(); QString selectedLangauge() { - QString locale = value("General/lang","").toString(); + auto locale = value(QStringLiteral("General/lang"), QString()).toString(); if (locale.isEmpty()) { locale = QLocale::system().bcp47Name(); int n = locale.indexOf("_");